Eli Mesika has posted comments on this change. Change subject: engine: Adding a helper function to check if table exists ......................................................................
Patch Set 3: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/37421/3/packaging/dbscripts/common_sp.sql File packaging/dbscripts/common_sp.sql: Line 429: declare Line 430: retvalue boolean; Line 431: BEGIN Line 432: retvalue := EXISTS ( Line 433: SELECT * FROM information_schema.tables WHERE table_schema = 'public' AND table_name = v_table PG is case insensitive for table names , so , maybe consider ILIKE here over the equals operation Line 434: ); Line 435: return retvalue; Line 436: END; $procedure$ Line 437: LANGUAGE plpgsql; -- To view, visit http://gerrit.ovirt.org/37421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9421526de442640cf985cb0302f7fa3d6daa909a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
