Liron Aravot has posted comments on this change.

Change subject: core: StorageHandlingCommandBase, Config values cleanup.
......................................................................


Patch Set 17:

(2 comments)

http://gerrit.ovirt.org/#/c/36318/17/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql:

Line 770: select fn_db_update_config_value('ServerCPUList','3:Intel Conroe 
Family:vmx,nx,model_Conroe:Conroe:x86_64; 4:Intel Penryn 
Family:vmx,nx,model_Penryn:Penryn:x86_64; 5:Intel Nehalem 
Family:vmx,nx,model_Nehalem:Nehalem:x86_64; 6:Intel Westmere 
Family:aes,vmx,nx,model_Westmere:Westmere:x86_64; 7:Intel SandyBridge 
Family:vmx,nx,model_SandyBridge:SandyBridge:x86_64; 8:Intel Haswell 
Family:vmx,nx,model_Haswell:Haswell:x86_64; 2:AMD Opteron 
G1:svm,nx,model_Opteron_G1:Opteron_G1:x86_64; 3:AMD Opteron 
G2:svm,nx,model_Opteron_G2:Opteron_G2:x86_64; 4:AMD Opteron 
G3:svm,nx,model_Opteron_G3:Opteron_G3:x86_64; 5:AMD Opteron 
G4:svm,nx,model_Opteron_G4:Opteron_G4:x86_64; 6:AMD Opteron 
G5:svm,nx,model_Opteron_G5:Opteron_G5:x86_64; 3:IBM POWER 
8:powernv,model_power8:power8:ppc64;','3.4');
Line 771: select fn_db_update_config_value('ServerCPUList','3:Intel Conroe 
Family:vmx,nx,model_Conroe:Conroe:x86_64; 4:Intel Penryn 
Family:vmx,nx,model_Penryn:Penryn:x86_64; 5:Intel Nehalem 
Family:vmx,nx,model_Nehalem:Nehalem:x86_64; 6:Intel Westmere 
Family:aes,vmx,nx,model_Westmere:Westmere:x86_64; 7:Intel SandyBridge 
Family:vmx,nx,model_SandyBridge:SandyBridge:x86_64; 8:Intel Haswell 
Family:vmx,nx,model_Haswell:Haswell:x86_64; 2:AMD Opteron 
G1:svm,nx,model_Opteron_G1:Opteron_G1:x86_64; 3:AMD Opteron 
G2:svm,nx,model_Opteron_G2:Opteron_G2:x86_64; 4:AMD Opteron 
G3:svm,nx,model_Opteron_G3:Opteron_G3:x86_64; 5:AMD Opteron 
G4:svm,nx,model_Opteron_G4:Opteron_G4:x86_64; 6:AMD Opteron 
G5:svm,nx,model_Opteron_G5:Opteron_G5:x86_64; 3:IBM POWER 
8:powernv,model_power8:power8:ppc64;','3.5');
Line 772: select 
fn_db_update_config_value('ClusterEmulatedMachines','rhel6.4.0,pc-1.0,pseries','3.3');
Line 773: select 
fn_db_update_config_value('SpiceDriverNameInGuest','{"windows": "RHEV-Spice", 
"linux" : "xorg-x11-drv-qxl" }','general');
Line 774: 
remove
Line 775: select 
fn_db_update_config_value('SupportedClusterLevels','3.0,3.1,3.2,3.3,3.4,3.5,3.6','general');
Line 776: select 
fn_db_update_config_value('SupportedStorageFormats','0,2,3','3.1,3.2,3.3,3.4,3.5,3.6');
Line 777: select 
fn_db_update_config_value('SupportedVDSMVersions','4.9,4.10,4.11,4.12,4.13,4.14,4.15,4.16,4.17','general');
Line 778: select fn_db_update_config_value('VdcVersion','3.6.0.0','general');


Line 839: 
------------------------------------------------------------------------------------
Line 840: --              Cleanup deprecated configuration values section
Line 841: 
------------------------------------------------------------------------------------
Line 842: 
Line 843: select 
fn_db_delete_config_value('SupportedStorageFormats','3.1,3.2,3.3,3.4,3.5');
what about 3.0/3.6?
Line 844: select 
fn_db_delete_config_value('AsyncPollingCyclesBeforeCallbackCleanup','general');
Line 845: select 
fn_db_delete_config_value('AsyncPollingCyclesBeforeRefreshSuspend','general');
Line 846: select fn_db_delete_config_value('AutoMode','general');
Line 847: select 
fn_db_delete_config_value('AutoSuspendTimeInMinutes','general');


-- 
To view, visit http://gerrit.ovirt.org/36318
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0c9bdc034fd09054ab11137bbc372514d3e74bc
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aavi...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to