Shubhendu Tripathi has posted comments on this change. Change subject: engine: vds commands for gluster brick create ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/36029/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/CreateBrickVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/CreateBrickVDSCommand.java: Line 35: Line 36: proceedProxyReturnValue(); Line 37: if (getVDSReturnValue().getSucceeded()) { Line 38: StorageDevice storageDevice = storageDeviceReturn.getStorageDevice(); Line 39: storageDevice.setVdsId(getParameters().getVdsId()); I feel this could be set in BLL itself and no need to pass to VDS command Line 40: storageDevice.setId(Guid.newGuid()); Line 41: setReturnValue(storageDevice); Line 42: } Line 43: } Line 36: proceedProxyReturnValue(); Line 37: if (getVDSReturnValue().getSucceeded()) { Line 38: StorageDevice storageDevice = storageDeviceReturn.getStorageDevice(); Line 39: storageDevice.setVdsId(getParameters().getVdsId()); Line 40: storageDevice.setId(Guid.newGuid()); as above Line 41: setReturnValue(storageDevice); Line 42: } Line 43: } Line 44: http://gerrit.ovirt.org/#/c/36029/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java: Line 308: public Map<String, Object> updateVmPolicy(Map info); Line 309: Line 310: public Map<String, Object> glusterStorageDevicesList(); Line 311: Line 312: public Map<String, Object> glusterCreateBrick(String brickName, String[] devices); How come two methods here? Also second one seems to have order of parameters different from defined in IVdsServer.java. Please check once. Line 313: Line 314: public Map<String, Object> glusterCreateBrick(String brickName, String[] devices, Map<String, Object> raidParams); -- To view, visit http://gerrit.ovirt.org/36029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a74a9eeabd19b9780e4401d263e586261f488d Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
