Shubhendu Tripathi has posted comments on this change. Change subject: engine: DB persistent quartz scheduler ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/36297/13/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImpl.java File backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImpl.java: Line 160: * To avoid data serialization issues for jobdata that is persisted in the database inpurParams should be of Line 161: * primitive or String type Line 162: */ Line 163: @Override Line 164: public String scheduleACronJob(Object instance, > I think introducing new APIs can be a separate patch. This patch is focusin Thats fine I feel. Once new patch comes, in we can use the same to set the endAt option from snapshot UI Line 165: String methodName, Line 166: Class<?>[] inputTypes, Line 167: Object[] inputParams, Line 168: String cronExpression) { -- To view, visit http://gerrit.ovirt.org/36297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34dac95999cb6b3721d201c116fb5f6089bb61 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
