Ala Hino has uploaded a new change for review.
Change subject: core: DetachDiskFromVmCommand
......................................................................
core: DetachDiskFromVmCommand
Minor fix.
Change-Id: I111ee52cb967ab97f1614b2b00bcfa9346a0f3b0
Signed-off-by: Ala Hino <ah...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/31/37231/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java
index e4daf4a..281f038 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java
@@ -67,8 +67,7 @@
// therefore for attached disk snapshot it shouldn't be checked
whether it has snapshots or not.
if (vmDevice.getSnapshotId() == null
&&
getDiskImageDao().getAllSnapshotsForImageGroup(disk.getId()).size() > 1) {
-
addCanDoActionMessage(VdcBllMessages.ERROR_CANNOT_DETACH_DISK_WITH_SNAPSHOT);
- retValue = false;
+ return
failCanDoAction(VdcBllMessages.ERROR_CANNOT_DETACH_DISK_WITH_SNAPSHOT);
}
}
return retValue;
--
To view, visit http://gerrit.ovirt.org/37231
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I111ee52cb967ab97f1614b2b00bcfa9346a0f3b0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ah...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
