Shubhendu Tripathi has posted comments on this change. Change subject: gluster: BLL queries for volume snapshots list and count ......................................................................
Patch Set 17: (2 comments) http://gerrit.ovirt.org/#/c/35674/17/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java: Line 348: dbFacade.getGlusterVolumeSnapshotConfigDao() Line 349: .getConfigByClusterIdAndName(volume.getClusterId(), Line 350: GlusterConstants.VOLUME_SNAPSHOT_MAX_HARD_LIMIT); Line 351: } Line 352: volume.setSnapMaxLimit(config != null ? Integer.valueOf(config.getParamValue()) : Integer.valueOf(0)); > Integer.valueOf(config.getParamValue()) : 0 ? Done Line 353: } Line 354: } Line 355: Line 356: private GlusterVolumeAdvancedDetails fetchAdvancedDatails(Guid volumeId) { http://gerrit.ovirt.org/#/c/35674/17/packaging/dbscripts/gluster_volumes_sp.sql File packaging/dbscripts/gluster_volumes_sp.sql: Line 591: WHERE id = v_id; Line 592: END; $procedure$ Line 593: LANGUAGE plpgsql; Line 594: Line 595: > this file can be skipped from this patch yes. will do that Line 596: Create or replace FUNCTION UpdateReplicaCount(v_volume_id UUID, Line 597: v_replica_count INTEGER) Line 598: RETURNS VOID Line 599: AS $procedure$ -- To view, visit http://gerrit.ovirt.org/35674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cd2a52c9bd10946b8702d833d6f8f0ebb3f848 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
