Vered Volansky has posted comments on this change. Change subject: core: Added a possibility to filter disks according explicitely set values ......................................................................
Patch Set 7: Code-Review-1 (3 comments) Reading again my former comment, I'm sorry for not being more clear. This version is indeed better when it comes to scopes, though I think class namings should be refined. But I think it would be best to implement this filtering in the DB level (which is what I meant by a new query...). Is there a good reason not to do it there? After the DB level you would probably need some Query class to access this. http://gerrit.ovirt.org/#/c/36060/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseGetAllAttachableDisksQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseGetAllAttachableDisksQuery.java: Line 9: Line 10: import java.util.ArrayList; Line 11: import java.util.List; Line 12: Line 13: public abstract class BaseGetAllAttachableDisksQuery<P extends GetAllAttachableDisks> extends QueriesCommandBase<P> { Naming - I would suggest BaseGetAttachableDisksQuery, as it's supposed to be a base for filtered as well. Line 14: Line 15: public BaseGetAllAttachableDisksQuery(P parameters) { Line 16: super(parameters); Line 17: } http://gerrit.ovirt.org/#/c/36060/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAttachableDisksFilteredByExplicitValuesQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAttachableDisksFilteredByExplicitValuesQuery.java: Line 4: import org.ovirt.engine.core.common.queries.GetAllAttachableDisksFilteredByExpliciteValues; Line 5: Line 6: import java.util.List; Line 7: Line 8: public class GetAllAttachableDisksFilteredByExplicitValuesQuery<P extends GetAllAttachableDisksFilteredByExpliciteValues> extends BaseGetAllAttachableDisksQuery<P> { The "All" here bothers me. How about: GetFilteredAttachableDisks ? Shorter too... Line 9: Line 10: public GetAllAttachableDisksFilteredByExplicitValuesQuery(P parameters) { Line 11: super(parameters); Line 12: } http://gerrit.ovirt.org/#/c/36060/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllAttachableDisksFilteredByExpliciteValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllAttachableDisksFilteredByExpliciteValues.java: Line 2: Line 3: import org.ovirt.engine.core.compat.Guid; Line 4: import org.ovirt.engine.core.compat.Version; Line 5: Line 6: public class GetAllAttachableDisksFilteredByExpliciteValues extends GetAllAttachableDisks { Same issue with the naming - GetFilteredAttachableDisks ? Line 7: Line 8: private int os; Line 9: Line 10: private Version vdsGroupCompatibilityVersion; -- To view, visit http://gerrit.ovirt.org/36060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If363cd92aa0071c88f2333294002ff8aa0da1b40 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Candace Sheremeta <csher...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
