Daniel Erez has posted comments on this change. Change subject: webadmin: Enabling ISO & Export path editing. ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/37336/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java: Line 474: } Line 475: Line 476: private boolean isDomainTypeValidForPathEditing(StorageDomain storage) { Line 477: StorageDomainType storageDomainType = storage.getStorageDomainType(); Line 478: return (storageDomainType.isInternalDomain() || storageDomainType == StorageDomainType.Master); doesn't 'isInternalDomain' already include 'Master'? Line 479: } Line 480: Line 481: private boolean isStorageStatusValidForPathEditing(StorageDomain storage) { Line 482: return (storage.getStatus() == StorageDomainStatus.Maintenance -- To view, visit http://gerrit.ovirt.org/37336 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a57fa74c4bbd41272f119925fa7fef9a67b267d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
