Martin Mucha has posted comments on this change. Change subject: core: long method refactor ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29588/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java: Line 209: compose(builder, "vds", logable.getVdsId().toString()); Line 210: compose(builder, "vm", emptyGuidToEmptyString(logable.getVmId())); Line 211: compose(builder, "template", emptyGuidToEmptyString(logable.getVmTemplateId())); Line 212: compose(builder, "customId", StringUtils.defaultString(logable.getCustomId())); Line 213: > please note, that ObjectId ended/ends with DELIMITER. I'd consider it as an need info Line 214: return builder.toString(); Line 215: } Line 216: Line 217: private static void compose(StringBuilder builder, String key, String value) { -- To view, visit http://gerrit.ovirt.org/29588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I832bc8c7e8bdfb2948f2137922e738fc6e702e59 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
