Moti Asayag has posted comments on this change.

Change subject: core: Add Network Filtering rules to VMs (#809814)
......................................................................


Patch Set 2: (3 inline comments)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HotPlugUnplgNicVDSParameters.java
Line 12:     private final VmNetworkInterface nic;
Line 13:     private final VmDevice vmDevice;
Line 14:     private final Version clusterVersion;
Line 15: 
Line 16:     public HotPlugUnplgNicVDSParameters(Guid vdsId, VM vm, 
VmNetworkInterface nic, VmDevice vmDevice) {
Done
Line 17:         super(vdsId);
Line 18:         this.vmId = vm.getId();
Line 19:         this.nic = nic;
Line 20:         this.vmDevice = vmDevice;


....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NetworkFilters.java
Line 3: /**
Line 4:  * The network filters defined by VDSM to be applied for the VM network 
interfaces.
Line 5:  */
Line 6: public enum NetworkFilters {
Line 7:     VDSM_NO_MAC_SPOOFING("vdsm-no-mac-spoofing");
Done
Line 8: 
Line 9:     private String filterName;
Line 10: 
Line 11:     private NetworkFilters(String filterName) {


....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 477: 
Line 478:     private static void addNetworkInterfaceProperties(XmlRpcStruct 
struct,
Line 479:             VmNetworkInterface vmInterface,
Line 480:             VmDevice vmDevice,
Line 481:             String nicModel, Version clusterVersion) {
Done
Line 482:         struct.add(VdsProperties.Type, vmDevice.getType());
Line 483:         struct.add(VdsProperties.Device, vmDevice.getDevice());
Line 484:         struct.add(VdsProperties.network, 
vmInterface.getNetworkName());
Line 485:         addAddress(vmDevice, struct);


--
To view, visit http://gerrit.ovirt.org/7356
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5776ea730ef1733fe4f9efe852c07053573dc5ba
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to