Maor Lipchuk has posted comments on this change.

Change subject: core: Add lock to a disk in attach to VM command (#834888)
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 263: VAR__HOST_STATUS__UP_MAINTENANCE_OR_NON_OPERATIONAL=$hostStatus Up, 
Maintenance or Non operational
Line 264: 
Line 265: ACTION_TYPE_FAILED_DISK_ALREADY_ATTACHED=Cannot ${action} ${type}. 
The disk is already attached to VM.
Line 266: ACTION_TYPE_FAILED_DISK_ALREADY_DETACHED=Cannot ${action} ${type}. 
The disk is already detached from VM.
Line 267: ACTION_TYPE_FAILED_NOT_SHAREABLE_DISK_ALREADY_ATTACHED=Cannot 
${action} ${type}. The disk is not sharable and is already attached to a VM.
/s/sharable/shareable
Line 268: ACTION_TYPE_FAILED_ILLEGAL_DISK_OPERATION=Cannot ${action} ${type}. 
Disk is Illegal. Illegal disks can only be deleted.
Line 269: ACTION_TYPE_FAILED_VM_MAX_RESOURCE_EXEEDED=Cannot ${action} ${type}. 
Maximum value for concurrently running VMs exceeded.
Line 270: ACTION_TYPE_FAILED_CPU_NOT_FOUND=Cannot ${action} ${type}. The chosen 
CPU is not supported.
Line 271: ACTION_TYPE_FAILED_EXCEEDED_MAX_PCI_SLOTS=Cannot ${action} ${type}. 
Maximum PCI devices exceeded.


--
To view, visit http://gerrit.ovirt.org/7337
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e47fe370b230b4bd69f108954031cda3bba6a3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to