Moti Asayag has posted comments on this change.
Change subject: engine: Obtain old network name from correct NIC (#849971)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java
Line 162: interfaces =
getInterfaceDAO().getAllInterfacesForVds(getParameters().getVdsId());
Line 163:
Line 164: for (final VdsNetworkInterface i :
getParameters().getInterfaces()) {
Line 165: VdsNetworkInterface updatedIface = null;
Line 166: for (VdsNetworkInterface iface : interfaces) {
Why not to use Entities.entitiesByName() in order to extract the interfaces
names into a map and to save the inner loop ?
Line 167: if (iface.getName().equals(i.getName())) {
Line 168: updatedIface = iface;
Line 169: }
Line 170:
--
To view, visit http://gerrit.ovirt.org/7410
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1311be342aa72bac9f1b79cec816be52f37d966d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
