Nir Soffer has posted comments on this change. Change subject: vdsm: use vdscli instead of vdsClient for storage operations ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/36798/2/src/plugins/ovirt-hosted-engine-setup/storage/storage.py File src/plugins/ovirt-hosted-engine-setup/storage/storage.py: Line 530 Line 531 Line 532 Line 533 Line 534 This is correct when using vdsClient "domain,domain" but *not* ok when using vdscli - it should be a list of uuids: domList = [sdUUID] Please check all other calls and ensure that each argument is using the correct type - check the schema for the correct type (vdsm/rpc/vdsmapi-schema.json). The best way to check this patch would be to compare the way you call vdscli, with the way vdsClient calls it. You can see that vdsClient creates a list of domains from the string argument: def createStoragePool(self, args): domList = args[4].split(",") ... -- To view, visit http://gerrit.ovirt.org/36798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec7db5ccf55752266fa668a8b1e8f914cd632521 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
