Lior Vernia has posted comments on this change. Change subject: webadmin: Add management role in cluster networks sub-tab ......................................................................
Patch Set 5: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/36411/5/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterNetworkView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterNetworkView.java: Line 99: Line 100: final NetworkCluster networkCluster = network.getCluster(); Line 101: if (networkCluster != null) { Line 102: Line 103: if (networkCluster.isManagement()) { Consider using the ternary operator here and in the next two blocks - will shorten the code significantly, and since the condition checking is so trivial should remain readable... But up to you, it's a style call. Line 104: images.add(managementImage); Line 105: } else { Line 106: images.add(emptyImage); Line 107: } -- To view, visit http://gerrit.ovirt.org/36411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2217c11574ba94e89f60164f53ba10468d9672ce Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
