Tal Nisan has posted comments on this change. Change subject: webadmin: Allow import of Posix/Gluster export storage domains ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37342/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java: Line 30: } Line 31: Line 32: private void initializeItems() { Line 33: List<IStorageModel> items = AsyncDataProvider.getIsoStorageModels(); Line 34: items.addAll(AsyncDataProvider.getInstance().getExportStorageModels()); > Are you sure this has been backported? Checkstyle is complaining about it. Of course not, just uploaded a first version, this and the logs are always an issue with backport Line 35: items.addAll(AsyncDataProvider.getFileDataStorageModels()); Line 36: items.addAll(AsyncDataProvider.getImportBlockDataStorageModels()); Line 37: Line 38: getModel().setItems(items); -- To view, visit http://gerrit.ovirt.org/37342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If81f45ba1956e838ca1fa7e89759bee3e55f3fe4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
