Allon Mureinik has posted comments on this change. Change subject: webadmin: Unabling storage domain's path editing while the domain is preparing to maintenance. ......................................................................
Patch Set 1: (2 comments) +1 on the code, the commit message needs some attention. http://gerrit.ovirt.org/#/c/37335/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-01-27 19:09:42 +0200 Line 4: Commit: Amit Aviram <aavi...@redhat.com> Line 5: CommitDate: 2015-01-28 09:01:52 +0200 Line 6: Line 7: webadmin: Unabling storage domain's path editing while the domain is preparing to maintenance. Disabling Line 8: Line 9: Storage domain's path editing should not be editable while the domain is Line 10: in PreparingForMaintenance mode. This patch restricts this issue. Line 11: Line 6: Line 7: webadmin: Unabling storage domain's path editing while the domain is preparing to maintenance. Line 8: Line 9: Storage domain's path editing should not be editable while the domain is Line 10: in PreparingForMaintenance mode. This patch restricts this issue. Requires an explanation WHY we're doing this. Line 11: Line 12: Change-Id: I8b24795b14428103bc65ba16f5737b1f8fd034ee -- To view, visit http://gerrit.ovirt.org/37335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b24795b14428103bc65ba16f5737b1f8fd034ee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
