Allon Mureinik has posted comments on this change. Change subject: core: hosts from gluser clusters shouldn't be considered ......................................................................
Patch Set 1: Code-Review-1 (3 comments) Are you sure you meant to push all these changes? http://gerrit.ovirt.org/#/c/37328/1/packaging/dbscripts/vds_sp.sql File packaging/dbscripts/vds_sp.sql: Line 412: v_pm_type VARCHAR(20) , Line 413: v_pm_user VARCHAR(50) , Line 414: v_pm_password VARCHAR(50) , Line 415: v_pm_port INTEGER , Line 416: v_pm_options VARCHAR(4000) , Why?! Line 417: v_pm_enabled BOOLEAN, Line 418: v_pm_proxy_preferences VARCHAR(255), Line 419: v_pm_secondary_ip VARCHAR(255), Line 420: v_pm_secondary_type VARCHAR(20), Line 421: v_pm_secondary_user VARCHAR(50), Line 422: v_pm_secondary_password text, Line 423: v_pm_secondary_port INTEGER, Line 424: v_pm_secondary_options VARCHAR(4000), Line 425: v_pm_secondary_concurrent BOOLEAN, Why?! Line 426: v_pm_detect_kdump BOOLEAN, Line 427: v_vds_spm_priority INTEGER, Line 428: v_sshKeyFingerprint VARCHAR(128), Line 429: v_console_address VARCHAR(255), Line 445: VALUES(v_vds_id,v_host_name, v_free_text_comment, v_ip, v_vds_unique_id, v_port, v_protocol, v_vds_group_id, v_vds_name, v_server_SSL_enabled, Line 446: v_vds_type,v_vds_strength,v_pm_type,v_pm_user,v_pm_password,v_pm_port,v_pm_options,v_pm_enabled, Line 447: v_pm_proxy_preferences, v_pm_secondary_ip, v_pm_secondary_type, v_pm_secondary_user, Line 448: v_pm_secondary_password, v_pm_secondary_port, v_pm_secondary_options, v_pm_secondary_concurrent, v_pm_detect_kdump, Line 449: v_vds_spm_priority, v_sshKeyFingerprint, v_console_address, v_ssh_port, v_ssh_username, v_disable_auto_pm, v_host_provider_id); huh? Line 450: END; Line 451: end if; Line 452: RETURN; Line 453: END; $procedure$ -- To view, visit http://gerrit.ovirt.org/37328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b89785529ec00114065e350138e05d6c966df44 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
