Roy Golan has posted comments on this change. Change subject: core: Make DAOs injectable ......................................................................
Patch Set 29: Code-Review-1 (1 comment) @Named is does not have a context . that could would behave differntly when we would have a container without the loading problem. we should have all the beans annotated exactly as if we would without the module bug and make the AfterBeanDiscovary deal with that namely all the beans brought here should be @Singelton or most of them http://gerrit.ovirt.org/#/c/35793/29/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDAODbFacadeImpl.java: Line 19: * <code>ActionGroupDAODbFacadeImpl</code> provides a concrete implementation of {@link ActionGroupDAO}. Line 20: * Line 21: * The initial implementation came from {@link org.ovirt.engine.core.dal.dbbroker.DbFacade}. Line 22: */ Line 23: @Named @Named is does not have a context . that could would behave differntly when we would have a container without the loading problem. we should have all the beans annotated exactly as if we would without the module bug and make the AfterBeanDiscovary deal with that Line 24: public class ActionGroupDAODbFacadeImpl extends BaseDAODbFacade implements ActionGroupDAO { Line 25: Line 26: private static final ConcurrentMap<VdcActionType, ActionVersionMap> cache = Line 27: new ConcurrentHashMap<VdcActionType, ActionVersionMap>(); -- To view, visit http://gerrit.ovirt.org/35793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia408a878fa0fa8dd8b414a60683c36d0db6d6641 Gerrit-PatchSet: 29 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
