Allon Mureinik has posted comments on this change. Change subject: db: refactoring upgrade process ......................................................................
Patch Set 4: Code-Review+1 (3 comments) http://gerrit.ovirt.org/#/c/37256/4//COMMIT_MSG Commit Message: Line 14: The squashing was done by creating a new schema including all the Line 15: squashed version changes and applying all inserts into the Line 16: insert_data.sql and insert_pre_defined_roles.sql manually Line 17: Line 18: This was a time consuming and error-prone process that leads sometimes s/leads sometimes/sometimes lead/ Line 19: to regressions since it was not easy to compare databases data using Line 20: pg_dump because PG does not guarantee the order in which data is dumped Line 21: even if the databases compared are identical. Line 22: Line 19: to regressions since it was not easy to compare databases data using Line 20: pg_dump because PG does not guarantee the order in which data is dumped Line 21: even if the databases compared are identical. Line 22: Line 23: This patch introduce a new approach when all data up to the squashed s/introduce/introduces/ Line 24: version, is auto generated per table by using pg_dump under the data Line 25: directory Line 26: Line 27: Another complementary tool (not part of this patch) enables to dump PG http://gerrit.ovirt.org/#/c/37256/4/packaging/dbscripts/data/0050_insert_roles.sql File packaging/dbscripts/data/0050_insert_roles.sql: Line 34: INSERT INTO roles (id, name, description, is_readonly, role_type, allows_viewing_children) VALUES ('def0000a-0000-0000-0000-def00000000d', 'VmCreator', 'User Role, permission to create VMs', true, 2, false); Line 35: INSERT INTO roles (id, name, description, is_readonly, role_type, allows_viewing_children) VALUES ('def0000a-0000-0000-0000-def00000000e', 'TemplateCreator', 'User Role, permission to create Templates', true, 2, false); Line 36: INSERT INTO roles (id, name, description, is_readonly, role_type, allows_viewing_children) VALUES ('def0000a-0000-0000-0000-def00000000f', 'TemplateOwner', 'User Role, permissions for all operations on Templates', true, 2, true); Line 37: INSERT INTO roles (id, name, description, is_readonly, role_type, allows_viewing_children) VALUES ('def0000a-0000-0000-0000-def000000010', 'NetworkUser', 'Network User', true, 2, false); Line 38: INSERT INTO roles (id, name, description, is_readonly, role_type, allows_viewing_children) VALUES ('def0000c-0000-0000-0000-def000000000', 'ExternalEventsCreator', 'External Events Creator', true, 2, false); Just to verify - this squashes all the custom roles added up to the squashed version, right? Line 39: Line 40: Line 41: -- Line 42: -- PostgreSQL database dump complete -- To view, visit http://gerrit.ovirt.org/37256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b8ecc31ca3a179886d84ae7f725282c5571c37 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
