Allon Mureinik has posted comments on this change. Change subject: core: Use new permission for LSM ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/37287/2/packaging/dbscripts/upgrade/03_06_0800_add_LSM_action_group_id.sql File packaging/dbscripts/upgrade/03_06_0800_add_LSM_action_group_id.sql: Line 10: -- copy the action group id to all the roles which has permissions to CONFIGURE_DISK_STORAGE (1103) Line 11: INSERT INTO roles_groups (role_id, action_group_id) Line 12: SELECT role_id, v_action_group_id Line 13: FROM roles_groups a Line 14: WHERE action_group_id = 1103; missing: "AND role_id <> 'DEF00006-0000-0000-0000-DEF000000011'". Otherwise, it invalidates the work done in 03_06_0770_add_vm_run_time_permissions.sql Line 15: Line 16: END; $procedure$ Line 17: LANGUAGE plpgsql; Line 18: -- To view, visit http://gerrit.ovirt.org/37287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ba7e03780ba6ef455447a4eaa34a71b1f63d8cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
