Ori Liel has posted comments on this change. Change subject: restapi: Add API to support warning for attached Storage Domains ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/36849/6/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 1528: headers: Line 1529: Content-Type: {value: application/xml|json, required: true} Line 1530: Correlation-Id: {value: 'any string', required: false} Line 1531: - name: /storagedomains/{storagedomain:id}/isattached|rel=isattached Line 1532: description: Querying if the Storage Domain is already attached to a Data Center by the is_attached boolean field, which is part of the storage domain object. It is not a part of the storage-domain object, it's some boolean in a configuration file on the storage server. That's why we can't simply have a boolean field returned by the standard GET call. Line 1533: request: Line 1534: body: Line 1535: parameterType: Action Line 1536: signatures: Line 1533: request: Line 1534: body: Line 1535: parameterType: Action Line 1536: signatures: Line 1537: - mandatoryArguments: {action.host.id|name: 'xs:string'} In the command implementation you're identifying the host only by it's ID. You're not looking at the name field at all. Either add code that can also identify the host by it's name, or remove the 'name' from here. Line 1538: optionalArguments: {} Line 1539: description: Line 1540: urlparams: Line 1541: async: {context: matrix, type: 'xs:boolean', value: true|false, required: false} -- To view, visit http://gerrit.ovirt.org/36849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b12e5ea2abea66cb950e3cdd64baaaff72a6919 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
