Alona Kaplan has posted comments on this change. Change subject: engine: Update UpdateStoragePoolCommand logic ......................................................................
Patch Set 36: (2 comments) http://gerrit.ovirt.org/#/c/33822/36/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java: Line 154: @Test Line 155: public void lowerVersionMgmtNetworkAndRegularNetworks() { Line 156: storagePoolWithLowerVersion(); Line 157: addNonDefaultClusterToPool(); Line 158: addNonManagementNetworksToPool(2); The test name is "lowerVersionMgmtNetworkAndRegularNetworks", I don't see here-' addManagementNetworksToPool()'. In addition, I think that you also should call "setupNetworkValidator(true)". Line 159: canDoActionFailed(VdcBllMessages.ACTION_TYPE_FAILED_CANNOT_DECREASE_COMPATIBILITY_VERSION); Line 160: } Line 161: Line 162: @Test Line 367: numberOfNetwworks s/numberOfNetwworks/numberOfNetworks -- To view, visit http://gerrit.ovirt.org/33822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf3a156bd711f0f044d256bab8c514c33ca66aa2 Gerrit-PatchSet: 36 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
