Alona Kaplan has posted comments on this change. Change subject: engine, webadmin: refactor manage networks flow ......................................................................
Patch Set 31: (2 comments) http://gerrit.ovirt.org/#/c/33684/31/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java: Seems that the changes in this file are not related and not used by the current patch. Line 1: package org.ovirt.engine.ui.uicommonweb; Line 2: Line 3: import java.io.Serializable; Line 4: import java.util.ArrayList; http://gerrit.ovirt.org/#/c/33684/31/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java: Line 174: final NetworkCluster networkCluster = new NetworkCluster(); Line 175: Line 176: networkCluster.setClusterId(manageModel.getCluster().getId()); Line 177: networkCluster.setNetworkId(manageModel.getEntity().getId()); Line 178: // networkCluster.setStatus(NetworkStatus.OPERATIONAL); // ??? Please remove the comment. Line 179: copyRoles(manageModel, networkCluster); Line 180: Line 181: return networkCluster; Line 182: } -- To view, visit http://gerrit.ovirt.org/33684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a0b86d8bb018a6172891cb357a4402cfef135d1 Gerrit-PatchSet: 31 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
