Roy Golan has posted comments on this change. Change subject: restapi: Fix ambigous error message ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37259/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java: Line 61: if (!storageDomainId.equals(fetchedDiskProfile.getStorageDomainId())) { Line 62: String diskProfileName = fetchedDiskProfile.getName(); Line 63: String targetStorageDomainName = getStorageDomain().getName(); Line 64: return new ValidationResult(VdcBllMessages.ACTION_TYPE_DISK_PROFILE_NOT_MATCH_STORAGE_DOMAIN, Line 65: String.format("$diskProfile %s", diskProfileName), personally I don't see what's wrong with "$diskProfile " + diskProfileName Line 66: String.format("$storageDomain %s", targetStorageDomainName)); Line 67: } Line 68: return ValidationResult.VALID; Line 69: } -- To view, visit http://gerrit.ovirt.org/37259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20106788bdd8a2b0f3008159c4b44dbbfaa443b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
