Lior Vernia has posted comments on this change. Change subject: webadmin: minor Java 7 related changes ......................................................................
Patch Set 2: Code-Review+2 (1 comment) Small comment. http://gerrit.ovirt.org/#/c/36913/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java: Line 163: @Override Line 164: public void onSuccess(Object model, Object result) Line 165: { Line 166: ClusterNetworkListModel clusterNetworkListModel = (ClusterNetworkListModel) model; Line 167: final List<Network> dcNetworks = (ArrayList<Network>) result; Might as well cast to List instead of ArrayList. Line 168: Line 169: ClusterNetworkManageModel networkToManage = createNetworkList(dcNetworks); Line 170: clusterNetworkListModel.setWindow(networkToManage); Line 171: networkToManage.setTitle(ConstantsManager.getInstance().getConstants().assignDetachNetworksTitle()); -- To view, visit http://gerrit.ovirt.org/36913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0734d5ec0c95f10240a6fe50bcda1a169d1d4a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
