Vered Volansky has uploaded a new change for review.

Change subject: core: Fine-tune Storage space alerts policy
......................................................................

core: Fine-tune Storage space alerts policy

Alerts were sent if the available space in GB (Integer) or percentage
were less or equal to the set thresholds. This patch changes it so
alerts would only be sent if the value is actually less than the
threshold.

Change-Id: Ic061ffc3e052a38fd9c923ffcc66eb1748ed60cf
Bug-Url: https://bugzilla.redhat.com/1178480
Signed-off-by: Vered Volansky <vvola...@redhat.com>
---
M 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/19/37219/1

diff --git 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
index 3830198..d9327c4 100644
--- 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
+++ 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
@@ -424,9 +424,9 @@
                     int freeDiskInGB = 
data.getStorageDynamicData().getfreeDiskInGB();
                     AuditLogType type = AuditLogType.UNASSIGNED;
                     boolean spaceThresholdMet =
-                            freeDiskInGB <= Config.<Integer> 
getValue(ConfigValues.FreeSpaceCriticalLowInGB);
+                            freeDiskInGB < Config.<Integer> 
getValue(ConfigValues.FreeSpaceCriticalLowInGB);
                     boolean percentThresholdMet =
-                            freePercent <= Config.<Integer> 
getValue(ConfigValues.FreeSpaceLow);
+                            freePercent < Config.<Integer> 
getValue(ConfigValues.FreeSpaceLow);
                     if (spaceThresholdMet && percentThresholdMet) {
                         type = AuditLogType.IRS_DISK_SPACE_LOW_ERROR;
                     } else {


-- 
To view, visit http://gerrit.ovirt.org/37219
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic061ffc3e052a38fd9c923ffcc66eb1748ed60cf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to