Martin Peřina has posted comments on this change. Change subject: core: Fix host status changed to Connecting logging ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/36964/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 925: VDS_ALERT_FENCE_NO_PROXY_HOST(9004), Line 926: VDS_ALERT_FENCE_STATUS_VERIFICATION_FAILED(9005, AuditLogSeverity.ALERT), Line 927: CANNOT_HIBERNATE_RUNNING_VMS_AFTER_CLUSTER_CPU_UPGRADE(9006, AuditLogSeverity.WARNING), Line 928: VDS_ALERT_SECONDARY_AGENT_USED_FOR_FENCE_OPERATION(9007, AuditLogSeverity.ALERT), Line 929: VDS_HOST_NOT_RESPONDING_CONNECTING(9008, AuditLogSeverity.WARNING), > Why removing the flood ? do we want that to flood the audit log events ??? It's not needed, because I moved logging command, so the message is logged only when host status changed from Up to Connecting (and that happens only once per flow). And IMHO that's the point when this message should be raised and not on every handleNetworkException() call as it currently happens. Line 930: VDS_ALERT_PM_HEALTH_CHECK_FENCE_AGENT_NON_RESPONSIVE(9009, AuditLogSeverity.ALERT), Line 931: VDS_ALERT_PM_HEALTH_CHECK_START_MIGHT_FAIL(9010, AuditLogSeverity.ALERT), Line 932: VDS_ALERT_PM_HEALTH_CHECK_STOP_MIGHT_FAIL(9011, AuditLogSeverity.ALERT), Line 933: VDS_ALERT_PM_HEALTH_CHECK_RESTART_MIGHT_FAIL(9012, AuditLogSeverity.ALERT), -- To view, visit http://gerrit.ovirt.org/36964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dfe369ea8c0a6460db9cc548b3695614a90d1b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
