Lior Vernia has posted comments on this change. Change subject: engine: Deprecate usage of network entries where possible ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37081/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 1317: Line 1318: boolean bridgedNetwork = isBridgedNetwork(network); Line 1319: HostNetworkQos qos = new HostNetworkQosMapper(network).deserialize(); Line 1320: Line 1321: Map<String, Object> effectiveBridge = > improper name Done Line 1322: (bridgesReported && bridgedNetwork && bridge != null) ? bridge : network; Line 1323: String addr = extractAddress(effectiveBridge); Line 1324: String subnet = extractSubnet(effectiveBridge); Line 1325: String gateway = (String) effectiveBridge.get(VdsProperties.GLOBAL_GATEWAY); -- To view, visit http://gerrit.ovirt.org/37081 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a46a277912b3a3013c379107f3cd6aa3cb52be9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
