Arik Hadas has posted comments on this change. Change subject: engine: Added init method to command base. ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37110/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 1057: addCanDoActionMessage(VdcBllMessages.FAILED_TO_INITIALIZE); Line 1058: return false; Line 1059: } Line 1060: return true; Line 1061: } > The requirement is to run it after permission check. my point regarding the return value is that it is not interesting - this is a hook for people to initialize the command, no checks should be made there. if there is a problem, it should be handled by can-do-action and more accurate message should be returned to the user. regarding the name, I don't need initExecution is good since it is relevant also for the canDoAction method. why just 'init' is not good? Line 1062: Line 1063: /** Line 1064: * This method should be inherited by subclasses that would like to perform initialization after permission check Line 1065: * -- To view, visit http://gerrit.ovirt.org/37110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c71548a8fab5538ee97c279f12a821999635950 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
