Tomas Jelinek has posted comments on this change. Change subject: webadmin: Migration options too small ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37048/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java: Line 991: isHighlyAvailableEditorWithDetachable = new EntityModelDetachableWidget(isHighlyAvailableEditor, Align.RIGHT); Line 992: overrideMigrationDowntimeEditorWithDetachable = new EntityModelDetachableWidget(overrideMigrationDowntimeEditor, Align.RIGHT); Line 993: overrideMigrationDowntimeEditor.getContentWidgetContainer().getElement().getStyle().setWidth(20, Unit.PX); Line 994: migrationModeEditorWithDetachable = new EntityModelDetachableWidget(migrationModeEditor, Align.RIGHT); Line 995: migrationModeEditor.getContentWidgetContainer().getElement().getStyle().setWidth(300, Unit.PX); > I am not a big fan of adding fixed width to editors like this. At the very OK, changed the EntityModelDetachableWidget in a way that it is now possible to set this up in the ui.xml Line 996: Line 997: StringEntityModelLabel rnglabel = new StringEntityModelLabel(); Line 998: rnglabel.setText(constants.rngDevEnabled()); Line 999: isRngEnabledCheckboxWithInfoIcon = new EntityModelWidgetWithInfo<String>(rnglabel, isRngEnabledEditor); -- To view, visit http://gerrit.ovirt.org/37048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ec2add329cbbe611c07f4eda2f70bacc8a9f3fc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
