Sahina Bose has posted comments on this change. Change subject: engine: DB persistent quartz scheduler ......................................................................
Patch Set 12: (6 comments) Patchset to follow http://gerrit.ovirt.org/#/c/36297/12/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImpl.java File backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImpl.java: Line 28: import org.quartz.SchedulerException; Line 29: import org.quartz.SchedulerFactory; Line 30: import org.quartz.impl.StdSchedulerFactory; Line 31: Line 32: // Singleton bean, named PersistentScheduler. > this comment is redundant - it is well implied by line 33. Done Line 33: @Singleton(name = "PersistentScheduler") Line 34: @DependsOn("LockManager") Line 35: @Startup Line 36: @TransactionAttribute(TransactionAttributeType.NOT_SUPPORTED) http://gerrit.ovirt.org/#/c/36297/12/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilBaseImpl.java File backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilBaseImpl.java: Line 267: } catch (SchedulerException se) { Line 268: log.error("failed to pause a job with id={}: {}", jobId, se.getMessage()); Line 269: log.debug("Exception", se); Line 270: } Line 271: > please remove empty line Done Line 272: } Line 273: Line 274: /** Line 275: * Delete the identified Job from the Scheduler Line 284: } catch (SchedulerException se) { Line 285: log.error("failed to delete a job with id={}: {}", jobId, se.getMessage()); Line 286: log.debug("Exception", se); Line 287: } Line 288: > please remove empty line Done Line 289: } Line 290: Line 291: /** Line 292: * resume a job with the given jobId assuming the job is in the default quartz group Line 300: } catch (SchedulerException se) { Line 301: log.error("failed to pause a job with id={}: {}", jobId, se.getMessage()); Line 302: log.debug("Exception", se); Line 303: } Line 304: > please remove empty line Done Line 305: } Line 306: Line 307: @Override Line 308: public void triggerJob(String jobId) { http://gerrit.ovirt.org/#/c/36297/12/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java File backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java: Line 36: @Startup Line 37: @TransactionAttribute(TransactionAttributeType.NOT_SUPPORTED) Line 38: @ConcurrencyManagement(ConcurrencyManagementType.BEAN) Line 39: public class SchedulerUtilQuartzImpl extends SchedulerUtilBaseImpl { Line 40: protected final Logger log = LoggerFactory.getLogger(SchedulerUtilQuartzImpl.class); > can't it be private ? Removing this. will use the super class logger instance. Line 41: /** Line 42: * This method is called upon the bean creation as part Line 43: * of the management Service bean lifecycle. Line 44: */ http://gerrit.ovirt.org/#/c/36297/12/packaging/dbscripts/upgrade/03_06_0710_insert_quartz_tables.sql File packaging/dbscripts/upgrade/03_06_0710_insert_quartz_tables.sql: Line 12: DROP TABLE IF EXISTS qrtz_simprop_triggers CASCADE; Line 13: DROP TABLE IF EXISTS qrtz_blob_triggers CASCADE; Line 14: DROP TABLE IF EXISTS qrtz_triggers CASCADE; Line 15: DROP TABLE IF EXISTS qrtz_job_details CASCADE; Line 16: DROP TABLE IF EXISTS qrtz_calendars CASCADE; > Please remove all DROP (even if exists by mistake in other scripts) K. done Line 17: Line 18: CREATE TABLE qrtz_job_details Line 19: ( Line 20: sched_name VARCHAR(120) NOT NULL, -- To view, visit http://gerrit.ovirt.org/36297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34dac95999cb6b3721d201c116fb5f6089bb61 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
