anmolbabu has posted comments on this change. Change subject: webadmin : Start geo-rep session ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/32538/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java: Line 165: } else { Line 166: if(getSelectedItems().size() == 1) { Line 167: GlusterGeoRepSession selectedSession = (GlusterGeoRepSession)getSelectedItem(); Line 168: allowStartSessionCommand = selectedSession .getStatus() == GeoRepSessionStatus.NOTSTARTED || selectedSession.getStatus() == GeoRepSessionStatus.STOPPED; Line 169: } > what if multiple volumes are selected? Done. Line 170: } Line 171: getNewSessionCommand().setIsAvailable(true); Line 172: getRemoveSessionCommand().setIsAvailable(false); Line 173: getStartSessionCommand().setIsExecutionAllowed(allowStartSessionCommand); Line 195: } else if (command.equals(getRefreshSessionsCommand())) { Line 196: refreshSessions(); Line 197: } else if(command.getName().equalsIgnoreCase("createSession")) {//$NON-NLS-1$ Line 198: setWindow(null); Line 199: //Action to follow in next patch > this should be removed from this patch I don't know if this had come somewhere in any of my old patch sets due to a rebase. I mean it was a part of another patch as rightly pointed. Line 200: } else if(command.getName().equalsIgnoreCase("closeConfirmationWindow")) {//$NON-NLS-1$ Line 201: closeConfirmationWindow(); Line 202: } else if(command.getName().equalsIgnoreCase("onStartGeoRepSession")) {//$NON-NLS-1$ Line 203: onStartGeoRepSession(); -- To view, visit http://gerrit.ovirt.org/32538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46fbd79f714175e3ad3ce76d858714c6fec3fdde Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
