Tal Nisan has posted comments on this change. Change subject: restapi: Enabling connection details viewing for ISO & Export domains. ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/36481/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java: Line 182: private String prepareEntityNamesForMessage(List<String> entityNames) { Line 183: return StringUtils.join(entityNames, ","); Line 184: } Line 185: Line 186: protected boolean isFileDomainInEditState(StorageDomain storageDomain) { This method can (and should be) private Line 187: return (storageDomain.getStatus() == StorageDomainStatus.Maintenance || storageDomain.getStorageDomainSharedStatus() == StorageDomainSharedStatus.Unattached); Line 188: } Line 189: Line 190: @Override -- To view, visit http://gerrit.ovirt.org/36481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab555a55899dc10bf7677d6ee5ee1fa4cc91f921 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
