Moti Asayag has posted comments on this change. Change subject: core: refactored RoleTreeView for reababilily purposes. ......................................................................
Patch Set 26: (1 comment) http://gerrit.ovirt.org/#/c/29899/26/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java: Line 53: Line 54: return roleTreeView; Line 55: } Line 56: Line 57: private static RoleNode categoryNode(String name, RoleNode... leaves) { the name is noun and imo doesn't represent well the real nature of this method. I wonder if adding create as prefix will do better and if a better place for this methods is in RoleNode class itself. Line 58: return new RoleNode(name, leaves); Line 59: } Line 60: Line 61: private static RoleNode categoryNode(String name, String tooltip, RoleNode... leaves) { -- To view, visit http://gerrit.ovirt.org/29899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I294e37d07a52c894e4293ca54f9cdb1003df8913 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
