Martin Mucha has posted comments on this change. Change subject: engine: Stop using network as DTO ......................................................................
Patch Set 1: Code-Review-1 (4 comments) http://gerrit.ovirt.org/#/c/37080/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java: Line 20: private VdsStatic vdsStatic; Line 21: private VdsDynamic vdsDynamic; Line 22: private VdsStatistics vdsStatistics; Line 23: private ArrayList<VdsNetworkInterface> interfaces; Line 24: private Set<String> networks; I'd prefer name 'networkNames' Line 25: private String activeNic; Line 26: private boolean balloonEnabled; Line 27: private boolean countThreadsAsCores; Line 28: private List<FenceAgent> fenceAgents; http://gerrit.ovirt.org/#/c/37080/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 1308: if (networks != null) { Line 1309: vds.getNetworks().clear(); Line 1310: for (Entry<String, Object> entry : networks.entrySet()) { Line 1311: String networkName = entry.getKey(); Line 1312: Map<String, Object> network = (Map<String, Object>) entry.getValue(); improper name Line 1313: if (network != null) { Line 1314: String interfaceName = (String) network.get(VdsProperties.INTERFACE); Line 1315: VdsNetworkInterface networkIface = vdsInterfaces.get(interfaceName); Line 1316: Map<String, Object> bridge = Line 1540: addBootProtocol((Map<String, Object>) nic.get("cfg"), vds, iface); Line 1541: } Line 1542: } Line 1543: Line 1544: private static String extractAddress(Map<String, Object> nic) { it's not 'nic', since it can be also 'network'. So proper name is probably 'properties' (of something) or something like that. Line 1545: return (String) nic.get("addr"); Line 1546: } Line 1547: Line 1548: private static String extractSubnet(Map<String, Object> nic) { Line 1544: private static String extractAddress(Map<String, Object> nic) { Line 1545: return (String) nic.get("addr"); Line 1546: } Line 1547: Line 1548: private static String extractSubnet(Map<String, Object> nic) { same Line 1549: return (String) nic.get("netmask"); Line 1550: } Line 1551: Line 1552: /** -- To view, visit http://gerrit.ovirt.org/37080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id32ee23132d505fc80a4e60b3a70d3453f5d0b35 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
