Kanagaraj M has posted comments on this change. Change subject: webadmin: Listing gluster volume snapshots ......................................................................
Patch Set 6: Code-Review+1 (1 comment) looks good apart from one minor comment http://gerrit.ovirt.org/#/c/36628/6/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java: Line 152: Line 153: TextColumnWithTooltip<GlusterVolumeEntity> snapshotCountColumn = new TextColumnWithTooltip<GlusterVolumeEntity>() { Line 154: @Override Line 155: public String getValue(GlusterVolumeEntity object) { Line 156: return object.getNoOfSnapshots().toString(); Can this be null? If yes, please add a null check Line 157: } Line 158: }; Line 159: snapshotCountColumn.makeSortable(); Line 160: getTable().addColumn(snapshotCountColumn, constants.noOfSnapshotsLabel(), "100px"); //$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/36628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1953aad3d013d386719a43b4bfdda82896cc3af Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
