Alona Kaplan has posted comments on this change. Change subject: engine: update UpdateVdsGroupCommand ......................................................................
Patch Set 34: (1 comment) http://gerrit.ovirt.org/#/c/33813/34/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/UpdateClusterNetworkClusterValidatorTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/UpdateClusterNetworkClusterValidatorTest.java: Line 37: Line 38: private void testUpdateManagementNetworkChange(boolean emptyCluster, Line 39: Matcher<ValidationResult> expectedResult) { Line 40: when(networkCluster.getClusterId()).thenReturn(TEST_CLUSTER_ID); Line 41: when(vdsDao.getAllForVdsGroup(TEST_CLUSTER_ID)).thenReturn(emptyCluster ? Yevgeny, please see the comment on patch set 25. You've marked it as done, but it is still unformatted. Please format it with the common formatter (you can find it in <ovirt-src-root>/config/engine-code-format.xml) Line 42: Collections.<VDS>emptyList() : Line 43: Collections.<VDS>singletonList(null)); Line 44: assertThat(validator.managementNetworkChange(), expectedResult); Line 45: } -- To view, visit http://gerrit.ovirt.org/33813 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica33589687a6190c1fa595beda461470afe9a6db Gerrit-PatchSet: 34 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
