Sahina Bose has posted comments on this change. Change subject: engine : Geo-rep config Vds Commands ......................................................................
Patch Set 6: (1 comment) Minor comment http://gerrit.ovirt.org/#/c/35972/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeConfigListXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeConfigListXmlRpc.java: Line 30: Line 31: private GlusterGeoRepSessionConfiguration getConfig(Map<String, Object> innerMap) { Line 32: GlusterGeoRepSessionConfiguration config = new GlusterGeoRepSessionConfiguration(); Line 33: config.setKey(innerMap.containsKey(OPTION_NAME) ? (String)innerMap.get(OPTION_NAME) : null); Line 34: config.setValue(innerMap.containsKey(DESCRIPTION) ? (String) innerMap.get(DESCRIPTION) : null); Is "description" the key for value in the returned map? Line 35: return config; Line 36: } Line 37: Line 38: public List<GlusterGeoRepSessionConfiguration> getSessionConfig() { -- To view, visit http://gerrit.ovirt.org/35972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I558ed18b94faae9d4b824c9de1fedda25ffc3f09 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
