Allon Mureinik has posted comments on this change. Change subject: core: Add role of VM run time manager. ......................................................................
Patch Set 2: Code-Review+1 (2 comments) Minor text comment - see inline. Eli - can you take a look too please? http://gerrit.ovirt.org/#/c/37094/2/packaging/dbscripts/upgrade/03_06_0760_add_VM_RUN_TIME_PERMISSIONS.sql File packaging/dbscripts/upgrade/03_06_0760_add_VM_RUN_TIME_PERMISSIONS.sql: Line 7: BEGIN Line 8: v_VM_RUN_TIME_MANAGER_ID := 'DEF00006-0000-0000-0000-DEF000000011'; Line 9: Line 10: -- Add user role for vm run time manager Line 11: INSERT INTO roles(id,name,description,is_readonly,role_type, app_mode) SELECT v_VM_RUN_TIME_MANAGER_ID, 'UserVmRunTimeManager', 'User Role, with permissions for any operations on Vms except snapshot manipulation', true, 2, 1 s/Vms/VMs/ Line 12: WHERE NOT EXISTS (SELECT id,name,description,is_readonly,role_type Line 13: FROM roles Line 14: WHERE id = v_VM_RUN_TIME_MANAGER_ID Line 15: AND name='UserVmRunTimeManager' Line 12: WHERE NOT EXISTS (SELECT id,name,description,is_readonly,role_type Line 13: FROM roles Line 14: WHERE id = v_VM_RUN_TIME_MANAGER_ID Line 15: AND name='UserVmRunTimeManager' Line 16: AND description='User Role, with permissions for any operations on Vms except snapshot manipulation' same comment Line 17: AND is_readonly=true Line 18: AND role_type=2 Line 19: AND app_mode=1); Line 20: -- To view, visit http://gerrit.ovirt.org/37094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc0e2484aabee5779d6bfaf44e25bab0511e8e16 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
