Alon Bar-Lev has posted comments on this change. Change subject: core, webadmin: Modify webadmin to use enginesso for authentication ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/36619/8/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SSOPostLoginServlet.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SSOPostLoginServlet.java: Line 51: } Line 52: Line 53: try { Line 54: InitialContext ctx = new InitialContext(); Line 55: try { > ctx.close() also throws a NamingException hmmm.... you can ignore/log this one, no? if you don't you won't get the initial exception (root cause). Line 56: JsonObjectDeserializer deserializer = new JsonObjectDeserializer(); Line 57: ExtMap principalRecord = deserializer.deserialize(request.getParameter("principalRecord"), ExtMap.class); Line 58: String principal = principalRecord.get(Authz.PrincipalRecord.PRINCIPAL); Line 59: String username = principal != null ? principal : principalRecord.<String>get(Authz.PrincipalRecord.NAME); -- To view, visit http://gerrit.ovirt.org/36619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff0aee9d0f5ee606ff7f397cab69017ca7d9df08 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
