Lior Vernia has posted comments on this change.

Change subject: engine: Ignore 'cfg' entries for cluster version >= 3.6
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.ovirt.org/#/c/36343/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BootProtocolResolver.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BootProtocolResolver.java:

Line 6: import org.ovirt.engine.core.common.businessentities.VDS;
Line 7: import 
org.ovirt.engine.core.common.businessentities.network.NetworkBootProtocol;
Line 8: import 
org.ovirt.engine.core.common.businessentities.network.VdsNetworkInterface;
Line 9: 
Line 10: public abstract class BootProtocolResolver {
> Since the class (and its children) deals with more than the boot protocol, 
It's been a while since I wrote the patch - that's actually not true. This only 
updates the boot protocol. Reverting name changes.
Line 11: 
Line 12:     protected final Map<String, Object> entry;
Line 13:     private final VdsNetworkInterface iface;
Line 14:     private final VDS host;


-- 
To view, visit http://gerrit.ovirt.org/36343
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If434111561aefab3d5d358a97331bcf3159f3484
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to