Eli Mesika has posted comments on this change. Change subject: engine: DB persistent quartz scheduler ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/36297/10/packaging/dbscripts/upgrade/03_06_0710_insert_quartz_tables.sql File packaging/dbscripts/upgrade/03_06_0710_insert_quartz_tables.sql: Line 12: DROP TABLE IF EXISTS qrtz_simprop_triggers CASCADE; Line 13: DROP TABLE IF EXISTS qrtz_blob_triggers CASCADE; Line 14: DROP TABLE IF EXISTS qrtz_triggers CASCADE; Line 15: DROP TABLE IF EXISTS qrtz_job_details CASCADE; Line 16: DROP TABLE IF EXISTS qrtz_calendars CASCADE; Aren't all those new tables (as I see below) , so , why you need to drop first, the upgrade mechanism insures that this script is not running twice so it should not be re-entrant Line 17: Line 18: CREATE TABLE qrtz_job_details Line 19: ( Line 20: sched_name VARCHAR(120) NOT NULL, -- To view, visit http://gerrit.ovirt.org/36297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34dac95999cb6b3721d201c116fb5f6089bb61 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
