Daniel Erez has posted comments on this change. Change subject: engine : Make Async Tasks Manager aware of child CoCo tasks ......................................................................
Patch Set 4: Verified+1 Code-Review+1 (1 comment) @Ravi - a general question, can we expand the infra so that the 'endSuccessfully' of the parent command will be invoked also when there are *only* CoCo (grand)child commands? http://gerrit.ovirt.org/#/c/36824/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 2343: } Line 2344: return SessionDataContainer.getInstance().getEngineSessionSeqId(sessionId); Line 2345: } Line 2346: Line 2347: protected VdcActionParametersBase withRootCommandInfo(VdcActionParametersBase params, VdcActionType actionType) { suggestion - to avoid casting, consider generify the signature to: "protected <P extends VdcActionParametersBase> P withRootCommandInfo(P params, VdcActionType actionType)" Line 2348: VdcActionType parentCommand = getParameters().getParentCommand() != VdcActionType.Unknown ? Line 2349: getParameters().getParentCommand() : actionType; Line 2350: params.setParentParameters(getParametersForTask(parentCommand, getParameters())); Line 2351: params.setParentCommand(parentCommand); -- To view, visit http://gerrit.ovirt.org/36824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d877309fd150280cd7ba6993b341a9044a4572f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
