Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Improve GWT build
......................................................................
webadmin,userportal: Improve GWT build
1. new Makefile variables with following defaults:
# Maven JVM options.
BUILD_JAVA_OPTS_MAVEN [-XX:MaxPermSize=512M]
# GWT compiler and Dev Mode JVM options.
BUILD_JAVA_OPTS_GWT []
Above variables can also be defined using env. variables,
so both examples below are valid use cases:
$ make clean install-dev [usual options] \
BUILD_JAVA_OPTS_GWT="..."
$ export BUILD_JAVA_OPTS_GWT="..." \
&& make clean install-dev [usual options]
In a typical environment, you'll want to:
* leave BUILD_JAVA_OPTS_MAVEN as it is
* define BUILD_JAVA_OPTS_GWT only if the build system is low
on physical memory, along with -Dgwt.compiler.localWorkers=1
to minimize GWT compiler memory footprint
If BUILD_JAVA_OPTS_GWT is empty (default), following fallback
value is used implicitly:
-Xms1024M -Xmx8192M \
-XX:PermSize=512M -XX:MaxPermSize=1024M
This is to ensure reasonable GWT compiler JVM options without
the need to customize BUILD_JAVA_OPTS_GWT for each build.
2. in Makefile "maven" target, changed:
export MAVEN_OPTS="..."
$(MVN) ...
to be:
MAVEN_OPTS="..." $(MVN)
3. in Makefile "gwt-debug" target, changed:
cd "path/to/gwt/module" && $(MVN) ...
to be:
$(MVN) -pl "path/to/gwt/module" ...
4. in "frontend modules" pom.xml, removed redundant <groupId>
as it's inherited from <parent> Maven module anyway.
Change-Id: Iaeb92d69f2ba38746559df3e44f34a61fd880908
Signed-off-by: Vojtech Szocs <vsz...@redhat.com>
---
M Makefile
M README.developer
M frontend/webadmin/modules/pom.xml
3 files changed, 39 insertions(+), 18 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Alexander Wels: Looks good to me, approved
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36739
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaeb92d69f2ba38746559df3e44f34a61fd880908
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Korren <bkor...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
