Alon Bar-Lev has posted comments on this change. Change subject: webadmin,userportal: Improve GWT build ......................................................................
Patch Set 7: Code-Review+1 (1 comment) great! http://gerrit.ovirt.org/#/c/36739/7/frontend/webadmin/modules/pom.xml File frontend/webadmin/modules/pom.xml: Line 53: -Djava.util.prefs.userRoot="${project.build.directory}/tmp" \ Line 54: ${gwt.jvmArgs} Line 55: </gwt-plugin.extraJvmArgs> Line 56: <!-- Custom JVM arguments for GWT compiler and Dev Mode --> Line 57: <gwt.jvmArgs>-Xms1024M -Xmx8192M -XX:PermSize=512M -XX:MaxPermSize=1024M</gwt.jvmArgs> better to put this before the above :))) just to avoid the question of what is gwt.jvmArgs while reading... not important. Line 58: <!-- Control target browsers for GWT compilation, maps to 'user.agent' deferred binding property in *.gwt.xml --> Line 59: <!-- By default, compile for Firefox browser only, use 'all-user-agents' profile to compile for all browsers --> Line 60: <gwt.userAgent>gecko1_8</gwt.userAgent> Line 61: <!-- Control target locales for GWT compilation, maps to 'locale' deferred binding property in *.gwt.xml --> -- To view, visit http://gerrit.ovirt.org/36739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaeb92d69f2ba38746559df3e44f34a61fd880908 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Korren <bkor...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
