Kanagaraj M has posted comments on this change. Change subject: webadmin : Geo-Replication action confirmation popup ......................................................................
Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/35224/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepActionConfirmationModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepActionConfirmationModel.java: Line 21: setMasterVolume(new EntityModel<String>()); Line 22: setSlaveVolume(new EntityModel<String>()); Line 23: setSlaveHost(new EntityModel<String>()); Line 24: setForce(new EntityModel<Boolean>()); Line 25: setMessage("");//$NON-NLS-1$ This is not required since you are checking for null in view Line 26: Line 27: getForce().setEntity(false); Line 28: } Line 29: http://gerrit.ovirt.org/#/c/35224/4/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java: Line 4010: @DefaultStringValue("Fetching Data") Line 4011: String fetchingDataMessage(); Line 4012: Line 4013: @DefaultStringValue("Warning : Recommendations for geo-replication not met -") Line 4014: String geoReplicationRecommendedConfigViolation(); Most of these are used in dependent patches? http://gerrit.ovirt.org/#/c/35224/4/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GeoRepActionConfirmPopUpView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GeoRepActionConfirmPopUpView.java: Line 94: @Override Line 95: public void edit(final GlusterVolumeGeoRepActionConfirmationModel object) { Line 96: driver.edit(object); Line 97: Line 98: forceEditor.setLabel(object.getForceLabel() == null ? constants.notAvailableLabel() : object.getMessage()); Why is this required? It should bind automatically Line 99: Line 100: messageLabel.setText(object.getMessage() == null ? constants.notAvailableLabel() : object.getMessage()); Line 101: } Line 102: Line 96: driver.edit(object); Line 97: Line 98: forceEditor.setLabel(object.getForceLabel() == null ? constants.notAvailableLabel() : object.getMessage()); Line 99: Line 100: messageLabel.setText(object.getMessage() == null ? constants.notAvailableLabel() : object.getMessage()); This should be done through presenter. You could refer snapshot ui patch for more info. Also can you check how this is done in Default Confirmation Popup view? Line 101: } Line 102: Line 103: @Override Line 104: public GlusterVolumeGeoRepActionConfirmationModel flush() { -- To view, visit http://gerrit.ovirt.org/35224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9bf8f15ca617de36b149b17b6ded7a81e52ab4b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
