Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Added range values to QoS error message. ......................................................................
webadmin: Added range values to QoS error message. On the Data Center tab, When adding a QoS to the cpu with limit which is out of range. The error message doesn't state what is the legal limit range. Now the range is added to the error message(The range is 1-100). Also, changed the name of the variable: ACTION_TYPE_FAILED_QOS_OUT_OF_RANGE_VALUES -> ACTION_TYPE_FAILED_QOS_CPU_OUT_OF_RANGE_VALUES A new variable for the "out of range" error was added for the storage which is named: ACTION_TYPE_FAILED_QOS_STORAGE_OUT_OF_RANGE_VALUES Change-Id: Ia0e1b2ef97624b6b0f3c9c95e7a09e15561a458b Bug-Url: https://bugzilla.redhat.com/1142333 Signed-off-by: Tomer Saban <tsa...@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/CpuQos.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/StorageQos.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 20 insertions(+), 10 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0e1b2ef97624b6b0f3c9c95e7a09e15561a458b Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
