Alex Lourie has posted comments on this change.
Change subject: packaging: fixed setup failure on missing file (#850330)
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File packaging/common_utils.py
Line 143: changed = False
Line 144: for i, line in enumerate(self.data[:]):
Line 145: if not re.match("\s*#", line):
Line 146: if re.match("\s*%s"%(param), line):
Line 147: self.data[i] = "%s=%s\n"%(param, value)
To be consistent, I recommend changing this to self.sep
Line 148: changed = True
Line 149: break
Line 150: if not changed:
Line 151: self.data.append("%s=%s\n"%(param, value))
Line 147: self.data[i] = "%s=%s\n"%(param, value)
Line 148: changed = True
Line 149: break
Line 150: if not changed:
Line 151: self.data.append("%s=%s\n"%(param, value))
same here
Line 152:
Line 153: def delParams(self, paramsDict):
Line 154: pass
Line 155:
--
To view, visit http://gerrit.ovirt.org/7392
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3166c233dfd29a715b0d5ed80e4ff59d23b40ae
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
