Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Remove general JVM settings from
gwt-plugin.extraJvmArgs
......................................................................
Patch Set 2:
TODO update patch according to discussion with Alon:
* preserve Java temp/prefs file settings in frontend pom.xml
* in Makefile maven target:
export MAVEN_OPTS="${MAVEN_OPTS} $(BUILD_JAVA_OPTS_COMMON)
$(BUILD_JAVA_OPTS_MAVEN)"
* set BUILD_JAVA_OPTS_COMMON to "" if not defined
* set BUILD_JAVA_OPTS_MAVEN to "-XX:MaxPermSize=512m" if not defined
* set BUILD_JAVA_OPTS_GWT to "-Xms1024M -Xmx8192M -XX:PermSize=512M
-XX:MaxPermSize=1024M" if not defined
* in frontend pom.xml:
<gwt-plugin.extraJvmArgs>
${gwt.jvmArgs} \
...
</gwt-plugin.extraJvmArgs>
* in Makefile when doing GWT build, ensure -Dgwt.jvmArgs =
$(BUILD_JAVA_OPTS_GWT)
--
To view, visit http://gerrit.ovirt.org/36739
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaeb92d69f2ba38746559df3e44f34a61fd880908
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Korren <bkor...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
