Vered Volansky has uploaded a new change for review. Change subject: core: Fix storage allocation check for LSM ......................................................................
core: Fix storage allocation check for LSM During LiveMigrateVmDisksCommand , a snapshot is taken on the source domain before actual migration. Validation should be for a new, empty AI (COW, SPARSE), but was done according to the actual disk data, which is not necessarily the above. Change-Id: I6417039be6c1e892b9d908f118a04f1a980e6702 Bug-Url: https://bugzilla.redhat.com/1099894 Signed-off-by: Vered Volansky <vvola...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/92/36892/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java index 96129a7..4525b68 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java @@ -462,7 +462,8 @@ StorageDomain sourceDomain = getStorageDomainById(sourceDomainId, storagePoolId); StorageDomainValidator storageDomainValidator = createStorageDomainValidator(sourceDomain); - if (!validate(storageDomainValidator.hasSpaceForNewDisks(disksList))) { + List<DiskImage> dummyDisksList = ImagesHandler.getDisksDummiesForStorageAllocations(disksList); + if (!validate(storageDomainValidator.hasSpaceForNewDisks(dummyDisksList))) { return false; } } -- To view, visit http://gerrit.ovirt.org/36892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6417039be6c1e892b9d908f118a04f1a980e6702 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
